Ensure dependabot doesn't break over time #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philiptaron
approved these changes
Nov 7, 2024
willbush
approved these changes
Nov 8, 2024
infinisil
force-pushed
the
fix-dependabot
branch
from
c3e2ab2 to
46f1763
Compare
infinisil
changed the title
infinisil
force-pushed
the
fix-dependabot
branch
from
46f1763 to
b7c7099
Compare
The automated GitHub workflow updates were broken for some time due to dependabot's images fetched at runtime went out of sync with the binary. While updating dependabot fixed it for now, a more permanent fix is to use the version of dependabot that pins the images at build time, introduced in NixOS/nixpkgs#352866 and NixOS/nixpkgs#354085
infinisil
force-pushed
the
fix-dependabot
branch
from
b7c7099 to
ad59d70
Compare
|
Turns out updates already work: #130 (comment), I updated the description and title to reflect that :) |
philiptaron
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automated GitHub workflow updates were broken for some time due to dependabot's images fetched at runtime went out of sync with the binary.
While updating dependabot fixed it for now, a more permanent fix is to use the version of dependabot that pins the images at build time, introduced in
NixOS/nixpkgs#352866 and NixOS/nixpkgs#354085
We still need to wait for the next channel update for the latter PR (https://nixpk.gs/pr-tracker.html?pr=354085) and then update the pinned Nixpkgs (https://github.com/NixOS/nixpkgs-vet/actions/workflows/update.yml) before we can merge this, but by having it open we shouldn't forget about it.